You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When invoking goto_reference, the current selection will always be saved to the jumplist, even if the goto command is cancelled by pressing Esc in the file picker.
When a goto command is cancelled, no effect is expected (except for querying LSP). But in current implementation, the jumplist will be tampered.
I think this issue can be fixed by the following patch, but I'm new to Rust and not sure if there are other use cases I haven't thought of.
Not modifying the jump list until jumping to a reference seems like better behavior to me. That change looks good - I just gave it a try and it works great! Would you like to submit a PR?
yzwduck
added a commit
to yzwduck/helix
that referenced
this issue
Jun 4, 2022
When invoking
goto_reference
, the current selection will always be saved to the jumplist, even if the goto command is cancelled by pressing Esc in the file picker.When a goto command is cancelled, no effect is expected (except for querying LSP). But in current implementation, the jumplist will be tampered.
I think this issue can be fixed by the following patch, but I'm new to Rust and not sure if there are other use cases I haven't thought of.
The text was updated successfully, but these errors were encountered: