Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding is now using gutter's color #3111

Closed
kchibisov opened this issue Jul 19, 2022 · 4 comments · Fixed by #3163
Closed

Padding is now using gutter's color #3111

kchibisov opened this issue Jul 19, 2022 · 4 comments · Fixed by #3163
Assignees
Labels
C-bug Category: This is a bug

Comments

@kchibisov
Copy link

Summary

After e8214fb the padding is now colored, which looks visually awful, since it's not really a padding anymore given that it closely visually attaches to line number.

An example of how it looks.

picture

The solution would be to use either a background color or provide a distinct color for it(using background color likely makes the most sense).

Reproduction Steps

No response

Helix log

No response

Platform

Linux

Terminal Emulator

alacritty

Helix Version

helix 22.05 (791bf7e)

@kchibisov kchibisov added the C-bug Category: This is a bug label Jul 19, 2022
@archseer
Copy link
Member

@pickfire

@pickfire pickfire self-assigned this Jul 21, 2022
@pickfire
Copy link
Contributor

pickfire commented Jul 21, 2022

@kchibisov Thanks for reporting this. Which theme are you using? I tried both onedark and default theme, it doesn't seem to have this issue.

@kchibisov
Copy link
Author

Try base16-default-dark. But you can go through the themes(they live update) and you'll find themes that look differently with and without your patch I ve mentined.

@archseer
Copy link
Member

archseer commented Jul 22, 2022

Let's do this: If gutters.is_empty() then automatically apply a 1 char margin and remove the spacer after the line number. That way the space between the view and the code isn't a gutter component but instead a margin. A spacer can then still be used to apply space inside the gutter, between different components.

pickfire added a commit to pickfire/helix that referenced this issue Jul 23, 2022
Remove padding gutter type, and automatically add 1 padding if gutters is
non-empty.

Fix helix-editor#3111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants