Mapped commands that would exit into normal mode do not propagate in history

[omentic]

Summary

I have many commands like C-s = ":write" set up in my configuration file, as I like having some base level of commands that work across all editors in addition to editor-specific commands. But something that bothers me a lot with Helix right now is that those commands don't increment the undo history.

If I ran :w normally, by exiting insert mode the undo history would be appended to. But since it's directly aliased, normal mode is never inserted and the undo history is never updated.

Reproduction Steps

https://asciinema.org/a/80czKCCbVB3wCja7zQLCCVii0

With this configuration:

[keys.insert]
C-s = ":write"
C-u = "undo"

Helix log

~/.cache/helix/helix.log

please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

Linux

Terminal Emulator

kitty 0.25.2

Helix Version

helix 22.05

[omentic]

Related: #1583

[dead10ck]

Related: #2883, and I would point you to my comment in that thread as well

[danielrode]

Workaround for the write command:

[keys.insert]
C-s = ["commit_undo_checkpoint", ":write"]

[omentic]

Fixed by #11062