Theme monokai_pro_spectrum uses a color magenta which is not defined as hex color in the [palette] section, causing hard to read low contrast

[LeoniePhiline]

Summary

monokai_pro_spectrum uses a color magenta which is not defined as hex color in the [palette] section.

Therefore, magenta's actual color depends on the terminal theme, causing terrible contrast for yellow on magenta errors.

Arguably, yellow on magenta has low contrast by definition (even if it was hex-coded) and thus is bound to be more or less hard to read.

The root cause is that unlike others, this theme uses red as color for builtin types, keywords and operators. Therefore, red is not a good error color. (See #2433)

Errors should either be marked by squiggly underlines (see #5236) or a new error color needs to be introduced, which might not be in line with the original vscode theme.

History:

• Change MonokaiProSpectrum theme error background from red to magenta. #3627
• Monokai pro spectrum theme shows error in yellow on red background #2433

Reproduction Steps

1. Cause an error in an LSP-enabled language
2. Hover the error location
3. See the bad contrast in the top right corner. (See screenshot above.)
4. For stronger effect, use a custom terminal emulator theme, e.g. Dracula, which makes magenta very vivid.

Expected:

Well readable error with reasonable highlight.

Helix log

Nothing special in Helix log.

Platform

openSUSE Tumbleweed - Linux

Terminal Emulator

Konsole

Helix Version

helix 22.12

[LeoniePhiline]

This comment has been resolved by merging #5250.

The theme also uses other non-hex-coded colors, such as "cyan":
https://github.com/helix-editor/helix/blob/master/runtime/themes/monokai_pro_spectrum.toml#L56

"cyan" should be #5ad4e6 according to the screenshot at https://www.vscolors.com/themes/f5d7ffda-c1d6-4070-ba80-803c705a1ee6-3ed72ace, which is in fact the palette color "blue".