Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): Replace non-palette color "magenta" with palette color "red" in monokai_pro_spectrum #5602

Conversation

LeoniePhiline
Copy link
Contributor

Fixes #5249

1f0a76f

"magenta" is not defined as hex code in the theme's palette and thus depends on the terminal emulator color theme.

This commit replaces the color with "red", which is defined.

a6eb461

After 1f0a76f, a remaining issue mentioned in #5249 is:

Arguably, yellow on magenta has low contrast by definition (even if it was hex-coded) and thus is bound to be more or less hard to read.

The root cause is that unlike others, this theme uses red as color for builtin types, keywords and operators. Therefore, red is not a good error color. (See #2433)

Note that #2433 should no longer be a problem, since #5419 was merged.

The second uses red + bold for "error", like a range of other themes:
ayu_dark, onelight, solarized_light, solarized_dark, onedarker, heisenberg, ayu_mirage, hex_steel, ayu_light, onedark

Example rust-analyzer error:
grafik

@CBenoit CBenoit added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 20, 2023
@the-mikedavis the-mikedavis merged commit 248a9f3 into helix-editor:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
3 participants