-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Dark Plus and add new maintainer #10574
Refactor Dark Plus and add new maintainer #10574
Conversation
Co-authored-by: NAME <NAME@EXAMPLE.COM>
Since you merged the PR you have all his commits so I would consider co-author unnecessary here. At some point @pascalkuthe and I would like to flesh out the But when merging this I would 'squash & merge' so that you are the author of the commit and make sure that @saccarosium is tagged as |
* Make dark_plus.toml more accurate to VSCode * theme(dark_plus): make type.builtin blue * Refactor dark_plus and add myself as new maintainer Co-authored-by: NAME <NAME@EXAMPLE.COM> --------- Co-authored-by: Luca Saccarola <96259932+saccarosium@users.noreply.github.com> Co-authored-by: Luca Saccarola <github.e41mv@aleeas.com> Co-authored-by: NAME <NAME@EXAMPLE.COM>
* Make dark_plus.toml more accurate to VSCode * theme(dark_plus): make type.builtin blue * Refactor dark_plus and add myself as new maintainer Co-authored-by: NAME <NAME@EXAMPLE.COM> --------- Co-authored-by: Luca Saccarola <96259932+saccarosium@users.noreply.github.com> Co-authored-by: Luca Saccarola <github.e41mv@aleeas.com> Co-authored-by: NAME <NAME@EXAMPLE.COM>
* Make dark_plus.toml more accurate to VSCode * theme(dark_plus): make type.builtin blue * Refactor dark_plus and add myself as new maintainer Co-authored-by: NAME <NAME@EXAMPLE.COM> --------- Co-authored-by: Luca Saccarola <96259932+saccarosium@users.noreply.github.com> Co-authored-by: Luca Saccarola <github.e41mv@aleeas.com> Co-authored-by: NAME <NAME@EXAMPLE.COM>
I have brought #8719 back from the dead, it was confirmed good by the previous theme maintainer @kirawi. It started out as a load of changes that mainly got rejected, and ended up as a really nice refactor making it much more readable.
I have merged in the new changes from master, and attempted to credit @saccarosium using the info from https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors in the commit details (with a temp email that might need updating if it is needed at all).
@the-mikedavis I am not sure if I need to add an accurate Co-authored-by: NAME NAME@EXAMPLE.COM in the commit to credit saccarosium, or maybe the fact I merged his closed PR and see his commits will do this automatically? If I need an email, how do I obtain the right email and do that.
@kirawi You asked me if I wanted to take over maintenance of this theme in the previous thread. I will have a go, cheers!
The only visible difference between the refactor and the previous version I can find is that the whitespace is now much better and more accurate to the original, here is VS Code:
and here is Helix with this PR
It used to be this, much too dark and in your face: