helix-term/commands: move SCRATCH_BUFFER_NAME to helix-view/document #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the name is accessible everywhere `Document` and related types are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the name is accessible everywhere Document and related types
are.
While working on #1035, I needed the name of the scratch buffer. However, since the const is defined in
helix-termand nothelix-view, I have no way to access it. This PR moves the const tohelix-view/src/document.rsso that the const is accessible everywhereDocumentand related types are.(I didn't think the original placement through, sorry. I swear, I'm not trying to pad my PR stats :P)