Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align selections #1101
align selections #1101
Changes from 7 commits
fdce4d8
00f611f
a7d5939
bb592bd
ca2bee8
1efa210
bac093c
09c5815
564a49b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think it's better to create an enum or reuse an existing one (if possible) for this, so we don't need
unimplemented!
.Also, I think it is better to use https://doc.rust-lang.org/std/primitive.slice.html#method.swap_with_slice
swap_with_slice
rather than having multiple allocations. We can just swap it twice and it should move all the whitespaces. The alternative is to useString::with_capacity
and push it manually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swap_with_slice
need twomut str
or string, but the trimmed or the fragment is not own by us, to use it we have make another string, which is same thing, right?