Add modified background to dracula popup

[stuarth]

Modifies the background color in the dracula theme so popup boundaries are clear.

Before

After

Still a bit low contrast, so happy to iterate on color, but vastly better having it distinguished. cc @loewenheim

[twe4ked]

I agree this is better than not having it, but FWIW I couldn't see the difference when I first looked at the screenshots. Would any other colors make sense?

[loewenheim]

This is a definite improvement. Personally I'd like a border around the popup, but I don't know if that's possible.

[Omnikar]

This is a definite improvement. Personally I'd like a border around the popup, but I don't know if that's possible.

We might be able to draw borders using these characters for edges, not sure about corners though.

▇   Top edge (swap bg and fg colors)
▎   Left edge
▋   Right edge (swap bg and fg colors)
▁   Bottom edge

[archseer]

We already have box drawing in helix-tui via Block and it supports a bunch of styles:

helix/helix-tui/src/widgets/block.rs

Lines 10 to 15 in 66afbc9

	pub enum BorderType {
	Plain,
	Rounded,
	Double,
	Thick,
	}

I avoided adding a border to popups though to reduce the size of the popup since the border would add another character of padding on each side.

[Omnikar]

I avoided adding a border to popups though to reduce the size of the popup since the border would add another character of padding on each side.

But it appears that currently there are spaces occupying the edges of the popups, couldn't those just be replaced with the box drawing characters?

[archseer]

We could do that and make it configurable. Generally we have a 1 char padding between the border and content on other windows (for example the auto info popup, picker, etc)

[archseer]

popup.border-type = "none"/"plain"/"rounded"

[archseer]

Merging this for now :) We can open another issue for borders