-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change show_subtree command into ':tree-sitter-subtree' typable command #1524
change show_subtree command into ':tree-sitter-subtree' typable command #1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is good to have this as default especially when this is used for debugging purposes. User can just add this to the config when they needed it.
If anything, I think maybe we could have :show_subtree
command so that user can run without changing the config. Even with the current one, it is not usable when the screen is small either way. Maybe writing to file is better.
I agree with @pickfire here. I don't see this meriting being in the default keymap. Adding a |
I like the sound of a typable command, I'll switch this PR to do that instead 👍 |
Is there a way to translate between |
I don't think there is a way to convert. But if you find it similar, then maybe you can do |
As it turns out, the Now adding the typable command I think it might be better to only have the typable command. I don't see too much utility in being able to have a keymap for it when I can just |
Yeah, I think this should be good. |
How about prefixing it with |
Taken from helix-editor/helix#1524 (comment) Cheers!
Following up on #1453 (comment), this is a default mapping for the new
show_subtree
command.To start off I have it under
space+t
which is what I've been using, since it's pretty similar presentation-wise to the LSP-driven documentation hoverspace+k
. I'm open to suggestions though.