Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ignore the .git directory in file picker #1604

Conversation

EpocSquadron
Copy link
Contributor

Some users (including myself) want to turn off filtering of files
prefixed with ., as they are often useful to edit. For example, .env
files, configuration for linters .eslint.json and the like.

@archseer
Copy link
Member

To see those it should be enough to turn on hidden files but keep the ignore/gitignore setting.

@EpocSquadron
Copy link
Contributor Author

EpocSquadron commented Jan 30, 2022

@archseer I'm sorry I got a bit confused in the commit message. The setting in question is hidden. If set to false, regardless of the setting of git-ignore or ignore, the .git directory entries show up in the file picker. The git-ignore setting does not guarantee that the .git directory is filtered out, only that the entries in the .gitignore files are. A workaround is to add .git to the .gitignore file, but that is a bit strange, since git itself does not require such an entry.

I'll adjust the commit message in the pull request to match this more clear explanation.

I've also considered the case in which the user wants to edit directly something in the .git folder, such as the .git/config file, and my answer to that is the :open command should suffice for such cases. I'm open to further discussion on it though.

Edit: Actually there's nothing wrong with my commit message or comment, it just wasn't as fleshed out. Leaving it for now unless you want me to adjust.

Some users (including myself) want to turn off filtering of files
prefixed with `.`, as they are often useful to edit. For example, `.env`
files, configuration for linters `.eslint.json` and the like.
@EpocSquadron EpocSquadron force-pushed the epocsquadron/always-ignore-git-directory branch from 2952234 to efb12b3 Compare February 19, 2022 05:50
@archseer archseer merged commit 700058f into helix-editor:master Feb 20, 2022
@EpocSquadron EpocSquadron deleted the epocsquadron/always-ignore-git-directory branch February 20, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants