update tree-sitter grammars #1728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
force-pushed
the
md-update-grammars
branch
2 times, most recently
from
c6c2baa to
82f825b
Compare
the-mikedavis
force-pushed
the
md-update-grammars
branch
from
82f825b to
24dfc71
Compare
for me TODO: - remove the remaining git assumption in the grammar - add "patch" to file types - test more diff results changes: - renamed to `tree-sitter-diff` as the grammar can handle various diff formats
changes: - typed fields within records which do not declare a default value are now correctly highlighted as record fields - the EEP49 'maybe' form is now parsed - fixes for highlights for 'begin' and 'after' tokens
news:
- tree-sitter-elixir now powers Elixir syntax highlighting on github.com
- GitHub now supports code-navigation for Elixir repos via
tree-sitter-elixir
changes:
- modules now use the `@module` highlight, which was added upstream to
tree-sitter
- it seems appropriate to use `@namespace` to follow helix convention
- added nullary range operator (e.g. `Enum.to_list(..) == []`), a new syntax
for elixir 1.14
- a fix for stab clause nodes mis-highlighting when the right hand side of
the stab clause contained multiple simple expressions
changes:
* the grammar has been completely rewritten in a way that removes
some of the "jumpiness" of the highlights
* when changing a command (for example from 'pick' to 'drop'),
highlighting would treat parts of the commit hash as a command
Note: we are not upgrading hashes because the more recent changes to the grammar leave it in worse shape than it was. I am working on fixing the new bugs, and we should be fine to upgrade once it's improved. changes: - highlights for the "or" keyword
the-mikedavis
force-pushed
the
md-update-grammars
branch
from
24dfc71 to
65b2219
Compare
|
There are too many grammars to update in one PR, will split out these existing updates into smaller focused PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the tree-sitter grammars have fallen out of date since they were added. This PR tries to bring things up to date.
This branch will probably outlive #1659, so instead of updating the submodule refs, I added the new revisions and remotes into the commit messages for now. I'll rebase eventually to either update the submodules or update languages.toml (if after #1659).
This PR is WIP while I carve through the existing grammars. It's not pressing to upgrade the grammars so I'll probably push to this every now and then as my time allows.
notable updates
tree-sitter-git-commithas a fix that makes it very fast on large verbose commitstree-sitter-git-rebasewas rewritten to be much less "jumpy" with the highlights during normal editing