Handle BrokenPipe when piping hx --health through head #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirmal-j-patel
force-pushed
the
health_handle_pipe
branch
from
d74959d
to
1e44768
Compare
sudormrfbin
reviewed
Mar 29, 2022
nirmal-j-patel
force-pushed
the
health_handle_pipe
branch
from
d32334c
to
f7d3e40
Compare
Functions in health.rs now return std:io::Result<()>. All instances of println! and eprintln! have been replaced with writeln!. This allows detection of errors while printing messages and errors. BrokenPipe errors are ignored. All other errors are returned. Fixes helix-editor#1841 Signed-off-by: Nirmal Patel <npate012@gmail.com>
sudormrfbin
force-pushed
the
health_handle_pipe
branch
from
f7d3e40
to
5496c27
Compare
sudormrfbin
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions in health.rs now return std:io::Result<()>. All instances of println!
and eprintln! have been replaced with writeln!. This allows detection of errors
while printing messages and errors. BrokenPipe errors are ignored. All other
errors are returned.
Fixes #1841
Signed-off-by: Nirmal Patel npate012@gmail.com