Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkmarks to health.rs output, Resolves #1894 #1918

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Added checkmarks to health.rs output, Resolves #1894 #1918

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aff621
Added checkmarks to health.rs output
Simon-Hostettler Apr 1, 2022
96a1027
replaced found/not found text with checkmarks
Simon-Hostettler Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions helix-term/src/health.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ pub fn languages_all() -> std::io::Result<()> {

for ts_feat in TsFeature::all() {
match load_runtime_file(&lang.language_id, ts_feat.runtime_filename()).is_ok() {
true => column("Found", Color::Green),
false => column("Not Found", Color::Red),
true => column("Found ✓", Color::Green),
false => column("Not Found ✘", Color::Red),
}
}

Expand Down Expand Up @@ -263,8 +263,8 @@ fn probe_treesitter_feature(lang: &str, feature: TsFeature) -> std::io::Result<(
let mut stdout = stdout.lock();

let found = match load_runtime_file(lang, feature.runtime_filename()).is_ok() {
true => "Found".green(),
false => "Not found".red(),
true => "Found ✓".green(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could replace the text with symbols altogether? \cc @sudormrfbin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this change in commit 96a1027

Copy link
Member

@sudormrfbin sudormrfbin Apr 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought just the symbol would make it look less readable, but it looks good 👍🏾

false => "Not found ✘".red(),
};
writeln!(stdout, "{} queries: {}", feature.short_title(), found)?;

Expand Down