Apply ui.gutter style to empty gutters #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unstyled column on the left from the diagnostics_or_breakpoints gutter looks sad if you want to add a background to all gutters. Let's fix this.
|
That empty gutter should be a |
|
@archseer the one on the right? yeah currently it's not a gutter, I might work on turning that gap into a gutter next. |
|
I think archseer is referring to #1967, so the gutters could be [editor]
gutters = ["spacer", "breakpoints", "diagnostics", "line-numbers"]by default. Then you could configure your gutters to remove the space altogether. |
|
Yes, but that would apply to the column on the right that I marked as "todo" on the screenshot. The column on the left is not a spacer, it is |
|
Ah I see, this applies the styling if gutter fn returns |
archseer
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unstyled column on the left from the diagnostics_or_breakpoints gutter looks sad if you want to add a background to all gutters. Let's fix this.