Soft wrap #2184
Closed
Soft wrap #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
force-pushed
the
soft-wrap
branch
3 times, most recently
from
5941231
to
cc05842
Compare
the-mikedavis
added
the
S-experimental
|
Hey there @kirawi, now that Markdown is supported out-of-the-box, I think it'd be great to be able to use soft wrap, seeing as we might be writing paragraphs and whatnot. I see you've merged a few changes since your last update to the PR, so just wondering what's missing or if editing is feasible yet? Thank you for your work on this! |
|
It's far from ready. I'm waiting for motivation to complete #3268 which entails implementing a cached line wrapper iterator. |
kirawi
added
the
S-waiting-on-pr
Maybe we can send cookies. |
|
Closing in favor of #5008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR will resolve #136. On Matrix, @cessen suggested splitting the overall soft-wrapping feature into two PRs for each of the two techniques he proposed. This PR will only implement the first, which should be enough for the majority of cases.
Status
The
Viewposition is not yet represented by acharoffset into the text, and so editing is not yet feasible. Rendering is also partial, as it will not correctly calculate the lines, won't wrap on a word break, nor will the cursor wrap to the next line once it goes past the screen. While I am reasonably confident about how to approach implementing this, it's being delayed by a lack of time on my part.Will depend upon #3268