Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable lsp request timeout #2405

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

EmmChriss
Copy link
Contributor

No description provided.

@ChrHorn
Copy link
Contributor

ChrHorn commented May 5, 2022

This would fix/simplify #669 btw. Issue is currently closed but still exists for people with slower hardware.

Not 100% if LanguageServerConfiguration is the right location. Think these are settings that are used by the external server, while timeout is a setting that is only used by the client.

Comment on lines +123 to +124
#[serde(default = "default_timeout")]
pub timeout: u64,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think many stuff here are not documented in the book, can you please put it there?

@archseer archseer merged commit 807cdc6 into helix-editor:master May 11, 2022
@EmmChriss EmmChriss deleted the timeout branch May 13, 2022 08:53
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants