Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prisma tree-sitter and lsp support #2703

Merged
merged 3 commits into from Jun 12, 2022
Merged

add prisma tree-sitter and lsp support #2703

merged 3 commits into from Jun 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2022

No description provided.

languages.toml Outdated Show resolved Hide resolved
@the-mikedavis
Copy link
Member

Overall this looks good but we may want to await victorhqc/tree-sitter-prisma#34. I can reproduce victorhqc/tree-sitter-prisma#34 (comment) within helix.

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
languages.toml Outdated

[[grammar]]
name = "prisma"
source = { git = "https://github.com/victorhqc/tree-sitter-prisma", rev = "0ac307e4be0409d4327082ddc737ed432a49dfc3" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source = { git = "https://github.com/victorhqc/tree-sitter-prisma", rev = "0ac307e4be0409d4327082ddc737ed432a49dfc3" }
source = { git = "https://github.com/victorhqc/tree-sitter-prisma", rev = "a3eaf13e75683cb22269814bf5e87af7eb671b1c" }

That issue got fixed so with this I think we'll be good to go 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that got fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check again with this commit? 36a8e66164babe9f588489c4d9f2b11ddb520ff3 If it stops happening, then I'll merge this PR and build a new release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Released v1.3.0 should not have the seg fault anymore.

@the-mikedavis
Copy link
Member

Thanks for working on this, looks great!

@the-mikedavis the-mikedavis merged commit 0bc7259 into helix-editor:master Jun 12, 2022
@ghost
Copy link
Author

ghost commented Jun 13, 2022

I added to wiki how to install default language server.

lazytanuki pushed a commit to lazytanuki/helix that referenced this pull request Jun 21, 2022
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
pimeys pushed a commit to prisma/docs that referenced this pull request Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants