add prisma tree-sitter and lsp support #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall this looks good but we may want to await victorhqc/tree-sitter-prisma#34. I can reproduce victorhqc/tree-sitter-prisma#34 (comment) within helix. |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
languages.toml
Outdated
|
|
||
| [[grammar]] | ||
| name = "prisma" | ||
| source = { git = "https://github.com/victorhqc/tree-sitter-prisma", rev = "0ac307e4be0409d4327082ddc737ed432a49dfc3" } |
There was a problem hiding this comment.
Suggested change
| source = { git = "https://github.com/victorhqc/tree-sitter-prisma", rev = "0ac307e4be0409d4327082ddc737ed432a49dfc3" } | |
| source = { git = "https://github.com/victorhqc/tree-sitter-prisma", rev = "a3eaf13e75683cb22269814bf5e87af7eb671b1c" } |
That issue got fixed so with this I think we'll be good to go 🙂
There was a problem hiding this comment.
Can you check again with this commit? 36a8e66164babe9f588489c4d9f2b11ddb520ff3 If it stops happening, then I'll merge this PR and build a new release.
There was a problem hiding this comment.
Released v1.3.0 should not have the seg fault anymore.
ghost
mentioned this pull request
the-mikedavis
approved these changes
Jun 12, 2022
|
Thanks for working on this, looks great! |
|
I added to wiki how to install default language server. |
lazytanuki
pushed a commit
to lazytanuki/helix
that referenced
this pull request
Jun 21, 2022
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
pimeys
pushed a commit
to prisma/docs
that referenced
this pull request
Jan 7, 2023
Support added last summer: helix-editor/helix#2703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.