Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixirLS disable dialyzer by default #2710

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

connorlay
Copy link
Contributor

Not all Elixir projects use dialyzer and it can cause the editor to slow down quite a bit on large projects if the PLT is not built.

See https://github.com/elixir-lsp/elixir-ls#dialyzer-integration=

Not all Elixir projects use dialyzer and it can cause the editor
to slow down quite a bit on large projects if the PLT is not built.

See https://github.com/elixir-lsp/elixir-ls#dialyzer-integration=
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable 👍

I don't think the dialyzer diagnostics have been that helpful in elixir anyways and it takes forever to make that initial plt file.

@the-mikedavis
Copy link
Member

I wouldn't expect helix to slow down if a language server is busy though unless it was competing for resources. Does it get choppy on large projects?

@connorlay
Copy link
Contributor Author

I wouldn't expect helix to slow down if a language server is busy though unless it was competing for resources. Does it get choppy on large projects?

I haven't profiled Helix to know for sure, but anecdotally I think it is probably the later that is causing the issue? This is on a fairly large monorepo Elixir project.

Disabling dialyzer seems to fix things for me locally 🤷🏻

@archseer archseer merged commit f37ffaa into helix-editor:master Jun 10, 2022
lazytanuki pushed a commit to lazytanuki/helix that referenced this pull request Jun 21, 2022
Not all Elixir projects use dialyzer and it can cause the editor
to slow down quite a bit on large projects if the PLT is not built.

See https://github.com/elixir-lsp/elixir-ls#dialyzer-integration=
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants