Better handling of symlinks #2718
Conversation
helix-term/src/ui/mod.rs
Outdated
| // Only list symlink if points to a file which we have permisson for | ||
| match std::fs::metadata(entry.path()).map(|meta| meta.is_file()) { | ||
| Err(_) | Ok(false) => None, | ||
| Ok(true) => Some(entry.into_path()), | ||
| } |
There was a problem hiding this comment.
maybe just setting follow_links(true) on the builder in this case would be better, would fix #2246 as well...
There was a problem hiding this comment.
I think so, fs::metadata is way too costly to run per-entry (out of potentially thousands). I specifically removed code calling fs::metadata from the completion functions 78fba86#diff-a2f72be0dae9186774ac716ae568f5216a5223dbf91e6ac8a25f62617c4fa55cL144
Actually, wouldn't this make more sense to do inside editor.open? Resolve the symlink, then either set_error "Not allowed to open the file" or open the file. I don't think files with insufficient permissions should just get hidden, it makes it seem like they're not there at all
There was a problem hiding this comment.
I've removed fs::metadata calls and changed to use follow_symlinks() instead. Added a configuration option to FilePicker to enable/disable following symlinks, so if it would lead to performance issues it can at least be toggled. Also error is now reported the same way like in :cd and :open if file picker fails. Hope I covered everything you mentioned.
- Add file-picker.follow-symlinks configuration option (default is true), this also controls if filename and directory completers follow symlinks. - Update FilePicker to set editor error if opening a file fails, instead of panicing. Fix helix-editor#1548 Fix helix-editor#2246
- Add file-picker.follow-symlinks configuration option (default is true), this also controls if filename and directory completers follow symlinks. - Update FilePicker to set editor error if opening a file fails, instead of panicing. Fix helix-editor#1548 Fix helix-editor#2246
Add file-picker.follow-symlinks configuration option (default is true), this
also controls if filename and directory completers follow symlinks.
Update FilePicker to set editor error if opening a file fails, instead of
panicing.
Fix #1548
Fix #2246