Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics picker formatting #2984

Merged
merged 5 commits into from
Jul 6, 2022
Merged

Improve diagnostics picker formatting #2984

merged 5 commits into from
Jul 6, 2022

Conversation

sudormrfbin
Copy link
Member

@sudormrfbin sudormrfbin commented Jul 6, 2022 •
edited
Loading

  • Remove source (usually the name of the LSP) from diagnostic picker display
  • Display diagnostic text before code in picker
  • Sub sort diagnostics by line number
  • Display error code only if not none
  • Show file path only in workspace diagnostic picker

Buffer diagnostic picker:

Before After
old-buffer new-buffer

Workspace diagnostic picker:

Before After
old-workspace new-workspace

archseer
archseer approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👍 we'll also align the filenames once Table support is present

@archseer archseer merged commit af35c62 into helix-editor:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudormrfbin @archseer