Fix Document::language_id returning None if there is no lang server #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used primarily to signal the document type to the LSP, I'm worried that such a change would completely break some languages. |
|
Aslo fixes an issue with #3273 where |
|
Merged #3338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2434 (comment) this was always returning
Noneif no language server was configured because of early returning with?operator.Also switched to relying on
config.language_idinstead of the last part of the scope because not all languages havescopeconfigured and sometimes scope is configured as"source.md"so we would end up with"md"but returning"markdown"would make more sense, at least for the purposes of #2434