Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different kinds of underline rendering #3015

Closed
wants to merge 5 commits into from
Closed

Support different kinds of underline rendering #3015

wants to merge 5 commits into from

Commits on Sep 7, 2022

  1. Support different kinds of underline rendering 

    Adds four new  modifiers that can be used in themes:

- undercurled
- underdashed
- underdotted
- double-underline
    @sudormrfbin
    sudormrfbin committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5902035 View commit details
    Browse the repository at this point in the history

  2. Add separate color for underlines

    @A-Walrus @sudormrfbin
    A-Walrus authored and sudormrfbin committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0296cdf View commit details
    Browse the repository at this point in the history

  3. Fix failing tests 

    Add underline field to doctests, and fix bugs
    @A-Walrus @sudormrfbin
    A-Walrus authored and sudormrfbin committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    394aa11 View commit details
    Browse the repository at this point in the history

  4. Update theme documentation

    @A-Walrus @sudormrfbin
    A-Walrus authored and sudormrfbin committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    523b987 View commit details
    Browse the repository at this point in the history

  5. Detect extended underline support using terminfo 

    The cxterminfo crate has been used over popular alternatives
like `term` since it supports querying for extended capabilities
and also for it's small codebase size (which will make it easy
to inline it into helix in the future if required).
    @sudormrfbin
    sudormrfbin committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    da52d20 View commit details
    Browse the repository at this point in the history