Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect count in treesitter movement #3058

Merged
merged 1 commit into from
Jul 14, 2022
Merged

respect count in treesitter movement #3058

merged 1 commit into from
Jul 14, 2022

Conversation

QiBaobin
Copy link
Contributor

No description provided.

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with this, but count does not seemed that useful for me in treesitter even though this makes it more consistent. I wonder what @the-mikedavis would say.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be useful 👍

You might want to jump two functions away or to the third argument/parameter. I think it's certainly better than having the count do nothing 😄

@pickfire pickfire merged commit 8681fb6 into helix-editor:master Jul 14, 2022
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants