add configurable / theme-able statusline separator string #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbromberger
changed the title
archseer
reviewed
Jul 26, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
…or#3175) * add configurable separator element to statusline * themable separator * clippy fixes * changed default separator to │ * doc updates
|
@sbromberger I have a hard time understanding why the separator is theme‐able.
It only adds complication. It can be fixed by customizing the themes and setting fg and bg to an empty string for the separator, but this shouldn’t be needed. |
|
@luetage this PR was merged ~5 months ago. I would suggest that any objection/reversion be proposed in a separate issue/PR. |
|
Alright, fair enough. Gonna take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable and themable statusline element called "separator" that can be used to provide visual separation of elements in the statusline. Like the spacer element in #3165, multiple / consecutive separators may be specified.
The PR adds a "separator" configuration key to
[editor.statusline], a "separator" element to be used inleft,right, andcenter, and aui.statusline.separatorkey for use by themes.