Add completion for nested settings #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings such as search.wrap-around are now also completed.
archseer
reviewed
Aug 2, 2022
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
approved these changes
Aug 6, 2022
|
Thank you!!! |
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested settings such as
search.wrap-aroundare now also completed.Addresses part of #2772 (show suggestion for sub-keys such as
cursor-shape.normalbut still no suggestions for valid values for that option)