Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosé Pine Moon Theme #3229

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Rosé Pine Moon Theme #3229

merged 1 commit into from
Aug 6, 2022

Conversation

atahabaki
Copy link
Contributor

@atahabaki atahabaki commented Jul 28, 2022

This is based on Rosé Pine theme...

Rose Pine Moon palette.

There's 3 reasons why i've opened this pr:

  1. I don't like Rose Pine theme, the Moon version is much more enjoyable
  2. I don't know any possible way to configure the theme in user config file...
  3. I don't want to modify /var/lib/helix/runtime/themes/ folder...

And I must say, helix is great. I liked it very much... Thanks

based on Rosé Pine theme...
@A-Walrus
Copy link
Contributor

About point 2, in order to add a theme for yourself add the rose_pine_moon.toml to your user theme folder (~/.config/helix/themes on linux). You can select it in the config file with theme = "rose_pine_moon"

@erasin
Copy link
Contributor

erasin commented Jul 29, 2022

theme document : https://docs.helix-editor.com/themes.html

@atahabaki
Copy link
Contributor Author

atahabaki commented Aug 1, 2022

I don't want to speak so confident, but most of the users are going to change the theme the way they want to see it. More eye-catching, easy-to-find and accessible theming docs mean more user, at least I think it is. I discovered theme docs after I created this pr.

@the-mikedavis the-mikedavis self-requested a review August 2, 2022 21:28
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Aug 2, 2022
@the-mikedavis
Copy link
Member

The docs.helix-editor.com docs code is here: https://github.com/helix-editor/helix/tree/master/book and the website code is here: https://github.com/helix-editor/website if you're interested in expanding them. I don't myself have any ideas for how to make them more noticeable though - we already link to the docs pretty prevasively throughout the project and IMO the theme docs are not very hard to find.

@atahabaki
Copy link
Contributor Author

atahabaki commented Aug 5, 2022

I've just updated the Themes page of the wiki, so others could find how they can install custom themes more easily. I usually choose to look at the wiki if there's one, then the docs. That's my problem, I suppose... Anyway, back to the topic, I think, that the website could show a few photos about themes/theming etc. I'm not a good designer so, I think it would be better if I don't touch that. Thanks, and I'm really sorry if I've just wasted your time.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the mix of purple compared to regular rose_pine 🎨

Could you add a screenshot to the themes wiki?

@the-mikedavis
Copy link
Member

Ah good call with the theme wiki link to the theme docs! I think it's definitely not unreasonable to visit the wiki first in a project :)

@the-mikedavis the-mikedavis merged commit 24f5a47 into helix-editor:master Aug 6, 2022
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants