Add cwd parameter which is not optional anymore #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwd field has been changed in helix-editor#2959 by making it a required field. However, when starting the debugging session, cwd is not set, causing an error in the deserialization part. Manually set cwd to the current directory as a quick fix.
|
Trying this locally it works for me when using DAP with Erlang. I don't see the "error in the deserialization part" you refer to on master though. Is that coming from debugging Rust? |
|
Yea, I am debugging a Rust program. The error is here: let arguments: dap::requests::RunInTerminalArguments =
serde_json::from_value(request.arguments.unwrap_or_default()).unwrap();
|
the-mikedavis
approved these changes
Jul 31, 2022
GreasySlug
pushed a commit
to GreasySlug/helix
that referenced
this pull request
Aug 2, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cwd field has been changed in #2959 by making it a required field.
However, when starting the debugging session, cwd is not set, causing
an error in the deserialization part. Manually set cwd to the current
directory as a quick fix.