Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nim language support. #3304

Closed
wants to merge 2 commits into from
Closed

Conversation

theherk
Copy link

@theherk theherk commented Aug 2, 2022

Fixes #3117.

I had some spare time, so I just grabbed the top task in the queue as a first. I'm a bit confused though because the language server does support completions, but that check doesn't get added. Further, even though I've linked the runtime in the branch and fetched and built grammar, that isn't checked either. In --health I get:

nim                  ✔ nimlangserver      None                 ✘                    ✘                    ✘

Not entirely sure why. Any ideas?

This is not yet supported by either language server.
@the-mikedavis
Copy link
Member

In order to perform syntax highlighting, indents and textobjects we also need queries https://docs.helix-editor.com/guides/adding_languages.html#queries

The tree-sitter-nim repo doesn't have example queries so you'll need to write them from scratch, or maybe nvim-treesitter has some to go off of.

See also #2633

I'm a bit confused though because the language server does support completions, but that check doesn't get added.

Those healthcheck checkmarks don't check for completion support: https://github.com/helix-editor/helix/wiki/Healthcheck#language-configuration-section

@theherk
Copy link
Author

theherk commented Aug 2, 2022

I understand more fully now. I'll remove and reopen when queries are complete.

@theherk theherk closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for nim-lang
2 participants