-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object selection (textobjects) #385
Conversation
While at this can you try to add |
I assume you mean move to next paragraph (like |
|
Feel free to land this without paragraph, etc. Those can come in a follow-up. |
I think that's better for now. I'll add the tests for the new word movements tomorrow and complete it :) |
It's the same as PrevWordEnd except for taking the current char into account, so use a "flag" to capture that usecase
They did not preserve anchor positions and were only used for textobject boundary search anyway so replace them with simple position finding functions
Can't find anything obviously wrong with this on a relatively shallow read. It looks good to me, so as longs as the test coverage is good and it's been manually tested, no complaints 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All-in-all this looks good to me. Not totally sure how I feel about the keybindings, but that's just bike-shedding. The functionality itself is good, and keybindings are probably best left to a holistic discussion of Helix's keymap.
Great work @sudormrfbin! 🎉 |
Closes #213.
Uses
ma
(match around) andmi
(match inside).TODO
maw
,miw
ma(
,mi"
,2ma[
, etcFuture Work