-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some vertical characters to the editor.indent-guides documentation #4163
Conversation
Can you show a screenshot of the two? |
Hello @archseer! Thanks for taking a look. I've added screenshots to the top comment. Was struggling to capture them earlier (nvidia issues). |
I prefer the center-aligned (current) character |
Yeah this seems like a preference thing that can be handled by the current config. |
I agree, but this looks like a more reasonable default, at least to me. Setting the center aligned pipe is easier as it's available on the keyboard. Switching to the left aligned one requires a user to search for the particular Unicode character and then copy and paste it into their config. That said, I'm fine with closing this as I've already updated my config :D |
We could add a few variants to the documentation, that way people will discover alternatives at the same time they discover the option, and keep the |
This sounds like a good idea. Makes it easy to switch and helps discoverability as well. I've updated the PR to add some characters to the documentation instead of changing the default. The more supported character is a good default. |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Thanks! |
Thank you, everyone! First commit to helix 🥳 |
helix-editor#4163) Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
helix-editor#4163) Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
This PR updates the default indent-guide character from a vertically aligned pipe (
|
) to a left aligned pipe (▏
).This makes a big difference visually as the indent guides are now aligned precisely to the indent level instead of starting half a character later.