-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands) increment by range #4418
Merged
CBenoit
merged 9 commits into
helix-editor:master
from
Bruce-Hopkins:feat-range-increment
Nov 11, 2022
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
32644a9
feat(commands) increment by range
Bruce-Hopkins 455c46c
added increasing increment as a new keymap
Bruce-Hopkins ee146f4
Changed keymapping for increasing increment
Bruce-Hopkins 0ac55c0
Changed range increment to work under a special register
Bruce-Hopkins 5b5d0a7
Added enum for increment feature
Bruce-Hopkins c5c59f3
removed amount parameter from increment_impl
Bruce-Hopkins d949f6e
cleaned increment code
Bruce-Hopkins 76ff510
removed enum numbers
Bruce-Hopkins fdd5e4b
formatted with cargo fmt
Bruce-Hopkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing amounts to
increase_impl
, we can create an enumAnd pass that to
increment_impl
, then check thecx.count
andcx.register
in the body ofincrement_impl
and then decide whether to use a positive or negative amount based on the passed direction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, won't we need a 3rd value for the enum if we don't want to increase it at all?
Alright, that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Count can't be 0 so we don't need a third member