Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic from two windows editing the same document #4570

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Fix panic from two windows editing the same document #4570

merged 3 commits into from
Nov 3, 2022

Commits on Nov 3, 2022

  1. Clamp highlighting range to be within document 

    This fixes a panic possible when two vsplits of the same document
exist and enough lines are deleted from the document so that one of
the windows focuses past the end of the document.
    @the-mikedavis
    the-mikedavis committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    41de475 View commit details
    Browse the repository at this point in the history

  2. Ensure cursor is in view on window change 

    If two windows are editing the same document, one may delete enough of
the document so that the other window is pointing at a blank page (past
the document end). In this change we ensure that the cursor is within
view whenever we switch to a new window (for example with `<C-w>w`).
    @the-mikedavis
    the-mikedavis committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e60266d View commit details
    Browse the repository at this point in the history

  3. Update helix-term/src/ui/editor.rs 

    Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
    @the-mikedavis @archseer
    the-mikedavis and archseer authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    ebb29bd View commit details
    Browse the repository at this point in the history