Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefix filtering from autocomplete menu #4578

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Remove prefix filtering from autocomplete menu #4578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b3056f
Remove prefix filtering from autocomplete menu
ChrHorn Nov 3, 2022
48eeaef
Merge branch 'master' into fuzzy-autocomplete
archseer Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions helix-term/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3950,7 +3950,6 @@ pub fn completion(cx: &mut Context) {
iter.reverse();
let offset = iter.take_while(|ch| chars::char_is_word(*ch)).count();
let start_offset = cursor.saturating_sub(offset);
let prefix = text.slice(start_offset..cursor).to_string();

cx.callback(
future,
Expand All @@ -3960,7 +3959,7 @@ pub fn completion(cx: &mut Context) {
return;
}

let mut items = match response {
let items = match response {
Some(lsp::CompletionResponse::Array(items)) => items,
// TODO: do something with is_incomplete
Some(lsp::CompletionResponse::List(lsp::CompletionList {
Expand All @@ -3970,15 +3969,6 @@ pub fn completion(cx: &mut Context) {
None => Vec::new(),
};

if !prefix.is_empty() {
items.retain(|item| {
item.filter_text
.as_ref()
.unwrap_or(&item.label)
.starts_with(&prefix)
});
}

if items.is_empty() {
// editor.set_error("No completion available");
return;
Expand Down