Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive global search #4687

Closed
wants to merge 4 commits into from
Closed

Interactive global search #4687

wants to merge 4 commits into from

Commits on Jun 5, 2023

  1. DynamicPicker: Pass compositor context to callback 

    This will be used in a child commit to setup an async job on the
compositor context within global_search's callback. The compositor
context was already available at the callback's callsite but was being
reduced to just the editor field.
    @the-mikedavis
    the-mikedavis committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    50fd8fa View commit details
    Browse the repository at this point in the history

  2. FilePicker: Allow setting an initial search query 

    This can be used to set an initial query from a register. Global
search will use this and the file picker could also consider allowing
an initial query using this helper.
    @the-mikedavis
    the-mikedavis committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    bdcb8c5 View commit details
    Browse the repository at this point in the history

  3. Global search: Show line contents

    @the-mikedavis
    the-mikedavis committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4f070ff View commit details
    Browse the repository at this point in the history

  4. Refactor global search to use a DynamicPicker 

    This commit refactors global search to use a DynamicPicker rather than
a prompt plus a picker based on the prompt entry. There aren't any
actual changes: the display format is the same (changed in the parent
commit) and the regex-matcher-builder and async collection are
essentially unchanged. Now these same blocks are used in the dynamic
picker's query callback.

The only novel code here is in the Err case for
RegexMatcherBuilder::build. We now open up a popup showing the failure
message for regexs that fail to compile.
    @the-mikedavis
    the-mikedavis committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3dbe90d View commit details
    Browse the repository at this point in the history