avoid reloading invalid views #4889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
force-pushed
the
reload-avoid-invalid-views
branch
from
245b9f3
to
b912d9c
Compare
mangas
force-pushed
the
reload-avoid-invalid-views
branch
from
b912d9c
to
eef3cca
Compare
Yes and no, it would not be needed but having this effectively prevents a regression if changes are made to the close mechanism or view map assumptions. Happy to close it if it's not needed :) |
Comment on lines
+1063
to
+1066
| .filter_map(|id| match cx.editor.tree.contains(id) { | ||
| true => Some(id), | ||
| false => None, | ||
| }) |
There was a problem hiding this comment.
I think clippy is saying here that this could be filter(|id| cx.editor.tree.contains(*id)) rather than a filter_map
There was a problem hiding this comment.
I think we should avoid being defensive here: by being defensive we might allow broken assumptions to cause hard-to-debug quirks
No worries, I wasnt sure how large a fix the close stuff would be so decided to check this route as well. I'll close the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4878