Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for showing all LSPs in --health #7315

Merged
merged 10 commits into from
Oct 16, 2023
60 changes: 44 additions & 16 deletions helix-term/src/health.rs
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,8 @@ pub fn languages_all() -> std::io::Result<()> {
.language
.sort_unstable_by_key(|l| l.language_id.clone());

let check_binary = |cmd: Option<String>| match cmd {
Some(cmd) => match which::which(&cmd) {
let check_binary = |cmd: Option<&str>| match cmd {
Some(cmd) => match which::which(cmd) {
Ok(_) => column(&format!("✓ {}", cmd), Color::Green),
Err(_) => column(&format!("✘ {}", cmd), Color::Red),
},
Expand All @@ -192,17 +192,15 @@ pub fn languages_all() -> std::io::Result<()> {
for lang in &syn_loader_conf.language {
column(&lang.language_id, Color::Reset);

// TODO multiple language servers (check binary for each supported language server, not just the first)

let lsp = lang.language_servers.first().and_then(|ls| {
let mut cmds = lang.language_servers.iter().filter_map(|ls| {
syn_loader_conf
.language_server
.get(&ls.name)
.map(|config| config.command.clone())
.map(|config| config.command.as_str())
});
check_binary(lsp);
check_binary(cmds.next());

let dap = lang.debugger.as_ref().map(|dap| dap.command.to_string());
let dap = lang.debugger.as_ref().map(|dap| dap.command.as_str());
check_binary(dap);

for ts_feat in TsFeature::all() {
Expand All @@ -213,6 +211,12 @@ pub fn languages_all() -> std::io::Result<()> {
}

writeln!(stdout)?;

cmds.try_for_each(|cmd| {
column("", Color::Reset);
check_binary(Some(cmd));
writeln!(stdout)
})?;
TheRealLorenz marked this conversation as resolved.
Show resolved Hide resolved
}

Ok(())
Expand Down Expand Up @@ -268,15 +272,12 @@ pub fn language(lang_str: String) -> std::io::Result<()> {
}
};

// TODO multiple language servers
probe_protocol(
probe_protocols(
"language server",
lang.language_servers.first().and_then(|ls| {
syn_loader_conf
.language_server
.get(&ls.name)
.map(|config| config.command.clone())
}),
lang.language_servers
.iter()
.filter_map(|ls| syn_loader_conf.language_server.get(&ls.name))
.map(|config| config.command.as_str()),
)?;

probe_protocol(
Expand All @@ -291,6 +292,33 @@ pub fn language(lang_str: String) -> std::io::Result<()> {
Ok(())
}

/// Display diagnostics about multiple LSPs and DAPs.
fn probe_protocols<'a, I: Iterator<Item = &'a str> + 'a>(
protocol_name: &str,
server_cmds: I,
) -> std::io::Result<()> {
let stdout = std::io::stdout();
let mut stdout = stdout.lock();
let mut server_cmds = server_cmds.peekable();

write!(stdout, "Configured {}s:", protocol_name)?;
if server_cmds.peek().is_none() {
writeln!(stdout, "{}", " None".yellow())?;
return Ok(());
}
writeln!(stdout)?;

for cmd in server_cmds {
let (path, icon) = match which::which(cmd) {
Ok(path) => (path.display().to_string().green(), "✓".green()),
Err(_) => (format!("'{}' not found in $PATH", cmd).red(), "✘".red()),
};
writeln!(stdout, " {} {}: {}", icon, cmd, path)?;
}

Ok(())
}

/// Display diagnostics about LSP and DAP.
fn probe_protocol(protocol_name: &str, server_cmd: Option<String>) -> std::io::Result<()> {
let stdout = std::io::stdout();
Expand Down
Loading