Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :log-open when --log is specified #7573

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Fix :log-open when --log is specified #7573

merged 2 commits into from
Jul 9, 2023

Commits on Jul 8, 2023

  1. fix & boyscout: ensure loader caches correct log file 

    Log file can be customized with `--log` argument, the `open-log` command
should respect that.

As part of this work, also done some boy-scouting around initialisation
of directories, cleaning up and making sure they happen in the same place.
    @alevinval
    alevinval committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    90978b6 View commit details
    Browse the repository at this point in the history

  2. Ensure parent dirs when initialising log and config files 

    Also, updated the getters to `unwrap()` as it seems silly to default again
in case the cell is not initialised. If the cell is not initialised
it would be a big programming error, as the first thing we do when starting
the editor is precisely that.
    @alevinval
    alevinval committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    c6c0644 View commit details
    Browse the repository at this point in the history