Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove the aarch64 appimage build steps from release #7832

Merged

Conversation

the-mikedavis
Copy link
Member

The steps mistakenly produce a x86_64 appimage and call it aarch64. linuxdeploy doesn't currently support producing aarch64 appimages so we should just remove these steps for aarch64-linux.

Closes #5237

The steps mistakenly produce a x86_64 appimage and call it aarch64.
linuxdeploy doesn't currently support producing aarch64 appimages so
we should just remove these steps for aarch64-linux.
@the-mikedavis the-mikedavis added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer. labels Aug 4, 2023
@gabydd
Copy link
Member

gabydd commented Aug 4, 2023

for anyone confused like I was, the ci is failing because GITHUB_REF_NAME becomes 7832/merge(see github/docs#15319) which has a slash in it so we refer to an uncreated directory which doesn't happen in the normal release process

@archseer archseer merged commit 86fc203 into helix-editor:master Aug 7, 2023
@the-mikedavis the-mikedavis deleted the remove-aarch64-appimage branch August 7, 2023 18:24
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
…r#7832)

The steps mistakenly produce a x86_64 appimage and call it aarch64.
linuxdeploy doesn't currently support producing aarch64 appimages so
we should just remove these steps for aarch64-linux.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
…r#7832)

The steps mistakenly produce a x86_64 appimage and call it aarch64.
linuxdeploy doesn't currently support producing aarch64 appimages so
we should just remove these steps for aarch64-linux.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…r#7832)

The steps mistakenly produce a x86_64 appimage and call it aarch64.
linuxdeploy doesn't currently support producing aarch64 appimages so
we should just remove these steps for aarch64-linux.
@agatekartik
Copy link

Appears there is a aarch64 now https://github.com/linuxdeploy/linuxdeploy/releases/download/1-alpha-20240109-1/linuxdeploy-aarch64.AppImage - will we see a corresponding helix AppImage soon?

@the-mikedavis
Copy link
Member Author

Feel free to submit a PR! (Once a linuxdeploy version with aarch64 support is released)

@agatekartik
Copy link

Feel free to submit a PR! (Once a linuxdeploy version with aarch64 support is released)

Thank you - yes might be a good idea, I tried a few things off the cuff (like undoing this commit and then ensuring aarch64 was used to create appimage) - however, from the runner output, looks like the binaries are not of the correct format - which means, while the linuxdeploy tool maybe aarch64, the binaries produced by the build are likely not (note: I haven't done a deep dive yet).
I shall fork and try locally with self hosted runners as time permits and see how to get things done, if they are indeed possible :-)

@agatekartik
Copy link

I tried getting the linuxdeploy-aarch64 tool to run on my raspberry pi 4. However, I keep getting a file format error of the linuxdeploy binary too. I guess it is best we remain patient till linuxdeploy announces release for aarch64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The helix-22.12-aarch64.AppImage is actually for x86
5 participants