Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Alt-Enter for the picker #7884

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

bjorn-ove
Copy link
Contributor

I found out about the existence of Alt-Enter when I noticed #7691 being merged. I then tested it in the space-f picker and found it worked there as well. Since this seems to be consistent behavior, I figured it should be documented.

@woojiq
Copy link
Contributor

woojiq commented Aug 9, 2023

I wanted to add the docs while working on that PR, but it completely slipped my mind. 👍️
Edit: I think "Open selected without closing picker" would be more informative.

pascalkuthe
pascalkuthe previously approved these changes Aug 9, 2023
| `Home` | Go to first entry |
| `End` | Go to last entry |
| `Enter` | Open selected |
| `Alt-Enter` | Open selected in the background |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `Alt-Enter` | Open selected in the background |
| `Alt-Enter` | Open selected without closing the picker |

I agree with woojiq: the "background" part of this might be confusing

Copy link
Contributor Author

@bjorn-ove bjorn-ove Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't change the current document, it opens hidden, and then you switch to it manually later. Not saying "in the background" is good, but I think "without closing the picker" is more confusing as nothing appears to be happening behind the picker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the point now. It is confusing that the picker doesn't close. But I still think it is also confusing that it doesn't open the focused window, so there is something missing. Perhaps what we would want is Opens selected in the background without closing the picker, however I guess that is too long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Open in background & keep picker open

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open selected in the background without closing the picker sounds good. It isn't too long, because if you look at docs you will find even longer description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm away from my computer until Monday, but will make the change as soon as possible. Feel free to close this PR and make a new one if necessary.

@the-mikedavis the-mikedavis added A-documentation Area: Documentation improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2023
@bjorn-ove
Copy link
Contributor Author

Updated

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2023
@pascalkuthe pascalkuthe merged commit 0a45fb4 into helix-editor:master Aug 15, 2023
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants