-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Alt-Enter for the picker #7884
Conversation
I wanted to add the docs while working on that PR, but it completely slipped my mind. 👍️ |
book/src/keymap.md
Outdated
| `Home` | Go to first entry | | ||
| `End` | Go to last entry | | ||
| `Enter` | Open selected | | ||
| `Alt-Enter` | Open selected in the background | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `Alt-Enter` | Open selected in the background | | |
| `Alt-Enter` | Open selected without closing the picker | |
I agree with woojiq: the "background" part of this might be confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it doesn't change the current document, it opens hidden, and then you switch to it manually later. Not saying "in the background" is good, but I think "without closing the picker" is more confusing as nothing appears to be happening behind the picker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the point now. It is confusing that the picker doesn't close. But I still think it is also confusing that it doesn't open the focused window, so there is something missing. Perhaps what we would want is Opens selected in the background without closing the picker
, however I guess that is too long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about Open in background & keep picker open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open selected in the background without closing the picker
sounds good. It isn't too long, because if you look at docs you will find even longer description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm away from my computer until Monday, but will make the change as soon as possible. Feel free to close this PR and make a new one if necessary.
31202ca
to
f070d83
Compare
Updated |
I found out about the existence of
Alt-Enter
when I noticed #7691 being merged. I then tested it in thespace-f
picker and found it worked there as well. Since this seems to be consistent behavior, I figured it should be documented.