-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
languages: add editorconfig #8076
Conversation
note that this is unrelated to #279; this is simply a highlighting grammar for .editorconfig files, which i felt was useful nonetheless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being able to highlight editorconfig syntax without support for editorconfig seems needless to me. In a pinch you can use the ini
language, so I don't think we need to add another language just for this use case
fair enough. should i turn this into a draft so we could look at it again when editorconfig support gets implemented? |
@the-mikedavis I think adding Line 2275 in 941dc6c
It's not 100% INI but the question would be whether highlighting correctly in most cases is better than not highlighting at all until Helix supports editorconfig directly. My assumption is that the files that aren't INI compatible are rare. (Although in all honesty I think being able to use the specific grammar in this PR even before adding official support is also a good idea) |
RE: Why you'd want this without support - Shared projects use EditorConfig files often, and being able to read them highlighted is a nicer experience even if Helix doesn't yet have the functionality to support them yet IMO |
INI seems like a nice compromise to me 👍. I'd like to avoid pulling in a special parser for the syntax if possible it anyways |
Superseded by #8308 |
note that this is unrelated to #279; this is simply a highlighting grammar for .editorconfig files, which i felt was useful regardless.
homepage, specification, tree-sitter grammar i wrote