languages: add templ #8540
Merged
languages: add templ #8540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsteube
force-pushed
the
templ
branch
2 times, most recently
from
98ebe2c
to
124d543
Compare
the-mikedavis
requested changes
Oct 17, 2023
the-mikedavis
added
S-waiting-on-author
|
It looks like the tree-sitter-templ scanner.c causes has some compilation errors on Windows |
D:\a\helix\helix\runtime\grammars\sources\templ\src\scanner.c(67): warning C4189: 'found': local variable is initialized but not referenced
D:\a\helix\helix\runtime\grammars\sources\templ\src\scanner.c(93): error C2016: C requires that a struct or union have at least one member
D:\a\helix\helix\runtime\grammars\sources\templ\src\scanner.c(341): warning C4244: 'function': conversion from 'int32_t' to 'wint_t', possible loss of dataIs it related to https://github.com/vrischmann/tree-sitter-templ/blob/master/src/scanner.c#L93 not having any member? |
|
Yep, I believe the warnings are benign but the error from the line you linked stops compilation |
the-mikedavis
approved these changes
Oct 21, 2023
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Oct 21, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added templ.
The captures probably still need some renaming.
Is the
structure.scmneeded?Quickstart
IDE Support