Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): add modus vivendi theme(s) #8894

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

matoous
Copy link
Contributor

@matoous matoous commented Nov 23, 2023

Add themes based on the dark variants of the modus themes (built-in with Emacs). This PR goes in line with #8728 and implements modus vivendi (dark) theme; reusing the original color palette.

modus_vivendi

Screenshot 2023-11-23 at 18 47 12

modus_vivendi_tritanopia

Screenshot 2023-11-23 at 18 48 31

modus_vivendi_deuteranopia

Screenshot 2023-11-23 at 18 47 45

modus_vivendi_tinted

Screenshot 2023-11-23 at 18 48 10


See Modus Themes Pictures for original.

Potentially more themes could be added in the future: https://protesilaos.com/emacs/ef-themes

@matoous matoous marked this pull request as ready for review November 23, 2023 17:48
@atahrijouti
Copy link
Contributor

Thank you for Prot's great themes. I've been craving Ef-themes and was looking into implementing them, would you happen to know if the structure is the same as modus operandi and vivendi?

@matoous
Copy link
Contributor Author

matoous commented Nov 24, 2023

@atahrijouti looking at https://github.com/protesilaos/ef-themes/blob/main/ef-dark-theme.el they should have the same structure. I tried it out here: https://github.com/matoous/helix/tree/md/ef-themes. Result:

Screenshot 2023-11-24 at 09 49 54

It might need some more adjustments. For example bg-paren-match highlight is missing but used by the modus themes.

@atahrijouti
Copy link
Contributor

That's really cool. Thanks :-)

@the-mikedavis
Copy link
Member

Could you add the license for these (https://protesilaos.com/emacs/modus-themes#h:b14c3fcb-13dd-4144-9d92-2c58b3ed16d3) following the new notes from #8861? That should make it easier to package downstream (fedora for example)

@matoous
Copy link
Contributor Author

matoous commented Nov 25, 2023

@the-mikedavis added, thanks! I missed that.

@matoous matoous changed the title feat(themes): add modus vivendi theme feat(themes): add modus vivendi theme(s) Nov 25, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to cut down on the duplication by using theme inheritance? It looks like most of the color names are the same so the variants could inherit the base theme and change the palette. See the gruvbox themes for an example

@matoous
Copy link
Contributor Author

matoous commented Nov 25, 2023

@the-mikedavis done, thanks.

the-mikedavis
the-mikedavis previously approved these changes Nov 26, 2023
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Nov 26, 2023
@saccarosium
Copy link
Contributor

I would advocate to define also the highlights for the bufferline:

"ui.bufferline" = { bg = "bg-tab-bar" }
"ui.bufferline.active" = { bg = "bg-tab-current", fg = "fg-mode-line-active" }

@matoous
Copy link
Contributor Author

matoous commented Nov 29, 2023

@saccarosium updated, thanks!

the-mikedavis
the-mikedavis previously approved these changes Nov 29, 2023
@archseer archseer merged commit 80dd585 into helix-editor:master Dec 19, 2023
6 checks passed
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants