-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for janet-lang #9081
Conversation
languages.toml
Outdated
file-types = ["janet"] | ||
comment-token = "#" | ||
indent = { tab-width = 2, unit = " " } | ||
roots = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This key can be omitted since #8803
Great to see this, but as far as I can tell, clojure-lsp listed in the PR requires openjdk installed on macos, which completely defeats the point of using janet in the first place. |
This PR doesn't configure a language server, it's just re-using the highlighting from clojure. If there's a language server for janet, that could be added in a follow-up PR |
Yes, I just realized. Sorry for the noise. |
FWIW, I have a branch based on a helix from 2023-10 or so that uses tree-sitter-janet-simple. The branch also includes a highlighting query file that works with the grammar. I was waiting for lsp support to improve, but perhaps that can be added later? Please let me know if there is any interest. |
Absolutely! 🚀 |
Ok, I've created a new branch that's based on 7e389b6. Before I make a PR, I have a few questions:
Hmm...perhaps better to make a PR and ask there? Update: made #9247. [1] There is more than one tree-sitter grammar for Janet -- though the other one I know of is not in use in Emacs or Neovim or elsewhere -- it took a different approach and possibly some folks might want to use it for certain situations. They were started around the same time but I changed the name of mine to avoid name collisions. |
* Add initial support for janet-lang * Use default roots for janet-lang
I've tried https://github.com/CFiggers/janet-lsp today and it's working. I've tested this on macOS with Janet installed through First I had to make sure that the location where binaries that are installed through export PATH=/opt/homebrew/Cellar/janet/HEAD-2f0c789/bin:$PATH I've (somewhat) followed the installation instructions from the README: git clone https://github.com/CFiggers/janet-lsp
cd janet-lsp
jpm -l deps
jpm install This is what I've put into [language-server.janet-lsp]
command = "janet-lsp"
[[language]]
name= "janet"
language-servers = [ { name = "janet-lsp" } ] |
* Add initial support for janet-lang * Use default roots for janet-lang
* Add initial support for janet-lang * Use default roots for janet-lang
* Add initial support for janet-lang * Use default roots for janet-lang
Resolves #4617 #4574