-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tmux.conf glob as a bash file type #9653
Conversation
Tmux and tmux.conf is used widely in software developer circles. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works".
Won't this break the support for the HOCON highlighting, which is defined later in the |
I don't really think it should be the default for any language, since it is used in so many different contexts. If folks would like it to be the default for their config language of choice, they should just make a local |
Yeah I was going to say something similar. If we already have a language for .conf it should be removed. Adding a specific glob pattern like tmux.conf as Mike said is fine tough I think |
In the particular case of tmux.conf, what we can do is name it It's the same for many tools that use the .conf format, in reality it does not matters. Now, what i read in this title is not that. What could be great is the ability to source Helix configs, just as shown here, as a regular Linux environment. That would allow to do cool things, without going in details, but for example to source text utilities and their shortcuts as a minor mode. It's another approach of a plugin system. Of course that is a Unix thing only. |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Thank you for your feedback. I updated the pull request with @the-mikedavis's suggestion, and the PR now uses globs. Let me know if you think this PR aligns with Helix's vision and priorities, it would certainly make my life easier if it landed, but I'm also not equipped to judge the side effects it may have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Add conf as a bash file type Tmux and tmux.conf is used widely in software developer circles. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works". * Use tmux.conf glob instead of simply conf for tmux Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add conf as a bash file type Tmux and tmux.conf is used widely in software developer circles. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works". * Use tmux.conf glob instead of simply conf for tmux Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add conf as a bash file type Tmux and tmux.conf is used widely in software developer circles. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works". * Use tmux.conf glob instead of simply conf for tmux Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add conf as a bash file type Tmux and tmux.conf is used widely in software developer circles. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works". * Use tmux.conf glob instead of simply conf for tmux Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add conf as a bash file type Tmux and tmux.conf is used widely in software developer circles. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works". * Use tmux.conf glob instead of simply conf for tmux Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add conf as a bash file type Tmux and tmux.conf is used widely in software developer circles. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works". * Use tmux.conf glob instead of simply conf for tmux Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Tmux and tmux.conf are used widely among Helix users. Having the tmux.conf file not have any syntax highlighting by default is (IMO) not ideal for an editor that otherwise "just works". Feel free to close without merge if you disagree, but I thought it's better I bring this up and give this change a chance to be merged.
Before
After