-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globbing support in :open
#9723
base: master
Are you sure you want to change the base?
Conversation
Great functionality, testing here and works good! |
I added an upper limit of files to open with a glob and implemented ignoring directories when globbing. The PR is ready to be merged after a review 😃 |
Currently this breaks opening non-existent file, e.g. |
@postsolar You are right. I will fix it in the next days. |
Fixed opening non-existent files and merge conflicts. |
I was too focused on skipping non-relevant parents 😅 I just use the parallel |
Closes #5706
The functionality is almost done, but I would like to have feedback on how to improve the error handling.
Please tell me if you prefer moving the two inner functions to somewhere else.
Things to discuss:
Should I ignore directories when globbing? Currently, running something likeUpdate: I ignore directories when globbing now.:open *
opens all files in the current directory and multiple file pickers for all directories in the current directory.