HTTP 500 when no signing key defined

[stnokott]

Hello,

after updating my self-hosted environment to f754f2b (after merge of #80), I kept getting HTTP 500.

Container logs

2024-04-25 09:17:40       Connection id "0HN34UV5C9ACI", Request id "0HN34UV5C9ACI:00000001": An unhandled exception was thrown by the application.
2024-04-25 09:17:40       System.ArgumentNullException: Value cannot be null. (Parameter 's')
2024-04-25 09:17:40          at System.ThrowHelper.ThrowArgumentNullException(ExceptionArgument) + 0x49
2024-04-25 09:17:40          at System.Convert.FromBase64String(String) + 0x32
2024-04-25 09:17:40          at Program.<>c__DisplayClass0_0.<<Main>$>b__5(JwtBearerOptions options) + 0x105
2024-04-25 09:17:40          at Microsoft.Extensions.Options.ConfigureNamedOptions`1.Configure(String, TOptions) + 0xaf
2024-04-25 09:17:40          at Microsoft.Extensions.Options.OptionsFactory`1.Create(String) + 0x114
2024-04-25 09:17:40          at Microsoft.Extensions.Options.OptionsMonitor`1.<>c.<Get>b__10_0(String name, IOptionsFactory`1 factory) + 0x42
2024-04-25 09:17:40          at Microsoft.Extensions.Options.OptionsCache`1.<>c__DisplayClass3_1`1.<GetOrAdd>b__2() + 0x43
2024-04-25 09:17:40          at System.Lazy`1.ViaFactory(LazyThreadSafetyMode) + 0xf1
2024-04-25 09:17:40          at System.Lazy`1.ExecutionAndPublication(LazyHelper, Boolean) + 0x76
2024-04-25 09:17:40          at System.Lazy`1.CreateValue() + 0xd1
2024-04-25 09:17:40          at System.Lazy`1.get_Value() + 0x28
2024-04-25 09:17:40          at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd[TArg](String, Func`3, TArg) + 0x2e6
2024-04-25 09:17:40          at Microsoft.Extensions.Options.OptionsMonitor`1.Get(String) + 0x27c
2024-04-25 09:17:40          at Microsoft.AspNetCore.Authentication.AuthenticationHandler`1.<InitializeAsync>d__48.MoveNext() + 0x120
2024-04-25 09:17:40       --- End of stack trace from previous location ---
2024-04-25 09:17:40          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x32
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xe9
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x88
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task, ConfigureAwaitOptions) + 0x31
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.GetResult() + 0x1c
2024-04-25 09:17:40          at Microsoft.AspNetCore.Authentication.AuthenticationHandlerProvider.<GetHandlerAsync>d__5.MoveNext() + 0x3ac
2024-04-25 09:17:40       --- End of stack trace from previous location ---
2024-04-25 09:17:40          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x32
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xe9
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x88
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task, ConfigureAwaitOptions) + 0x31
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() + 0x26
2024-04-25 09:17:40          at Microsoft.AspNetCore.Authentication.AuthenticationService.<AuthenticateAsync>d__14.MoveNext() + 0x326
2024-04-25 09:17:40       --- End of stack trace from previous location ---
2024-04-25 09:17:40          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x32
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xe9
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x88
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task, ConfigureAwaitOptions) + 0x31
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() + 0x26
2024-04-25 09:17:40          at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.<Invoke>d__6.MoveNext() + 0x89f
2024-04-25 09:17:40       --- End of stack trace from previous location ---
2024-04-25 09:17:40          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x32
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xe9
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task, ConfigureAwaitOptions) + 0x88
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task, ConfigureAwaitOptions) + 0x31
2024-04-25 09:17:40          at System.Runtime.CompilerServices.TaskAwaiter.GetResult() + 0x1c
2024-04-25 09:17:40          at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.<ProcessRequests>d__238`1.MoveNext() + 0x591

After a bit of trial & error, I realized that I need to provide a Signing Key to fix this (-e Helldivers__API__Authentication__SigningKey).

I'm opening this discussion to check if that's really the root isse or if I missed something.
If my assumption is right, I'll open an MR with an update to docs/containers.md, explaining this step.
(Additionally, perhaps also explaining the /dev/token endpoint which is also not documented to my knowledge)

Let me know what you think @dealloc .

[dealloc]

you need to provide a signing key for the API key feature to work, you're right that this should be updated in the docs (my bad!)

I'll see about adding some docs for this tonight

[dealloc]

created an issue for this in #90

[stnokott]

Would've volunteered to create an MR myself, but you're right, it's probably better if someone who has actually implemented this creates the documentation for it. 😉

[dealloc]

I very much appreciate the contributions!
in this case I'm the one who broke the documentation, so i figured I'd fix it 😅