Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate metrics from Opencensus to Opentelemetry #245

Merged
merged 11 commits into from
Dec 15, 2022

Conversation

s-radyuk
Copy link
Contributor

@s-radyuk s-radyuk commented Dec 12, 2022

This PR migrates Kangal from using Opencensus to Opentelemetry:

  • both proxy and controller use go.opentelemetry Prometheus exporter
  • countRunningLoadtests metric collected asynchronously in proxy
  • reconciler tag is removed from metrics, as we have only one reconciler in code and it's always the same
  • all server methods use otelhttp.NewHandler to collect http metrics
  • no new logic introduced

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #245 (8e2155c) into master (bcedc5a) will decrease coverage by 0.98%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   56.87%   55.88%   -0.99%     
==========================================
  Files          37       37              
  Lines        4032     4103      +71     
==========================================
  Hits         2293     2293              
- Misses       1615     1686      +71     
  Partials      124      124              
Impacted Files Coverage Δ
cmd/controller.go 20.37% <0.00%> (-2.08%) ⬇️
cmd/proxy.go 0.00% <0.00%> (ø)
pkg/controller/controller.go 0.00% <0.00%> (ø)
pkg/controller/loadtest.go 2.99% <0.00%> (-0.18%) ⬇️
pkg/controller/metrics.go 0.00% <0.00%> (ø)
pkg/kubernetes/client.go 83.75% <0.00%> (-6.80%) ⬇️
pkg/proxy/proxy.go 78.72% <0.00%> (-6.93%) ⬇️
pkg/proxy/server.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@s-radyuk s-radyuk marked this pull request as ready for review December 14, 2022 15:12
@s-radyuk s-radyuk merged commit 4e2ce2b into master Dec 15, 2022
@s-radyuk s-radyuk deleted the feature/migrate-to-opentel branch December 15, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants