-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate metrics from Opencensus to Opentelemetry #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 56.87% 55.88% -0.99%
==========================================
Files 37 37
Lines 4032 4103 +71
==========================================
Hits 2293 2293
- Misses 1615 1686 +71
Partials 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
s-radyuk
force-pushed
the
feature/migrate-to-opentel
branch
from
December 13, 2022 15:19
80eb1fb
to
07d7c26
Compare
s-radyuk
force-pushed
the
feature/migrate-to-opentel
branch
from
December 14, 2022 14:55
939925d
to
8e2155c
Compare
lucasmdrs
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates Kangal from using Opencensus to Opentelemetry:
countRunningLoadtests
metric collected asynchronously in proxyreconciler
tag is removed from metrics, as we have only one reconciler in code and it's always the sameotelhttp.NewHandler
to collect http metrics