Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache directory path always in PATH env #99

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

Xplouder
Copy link
Contributor

@Xplouder Xplouder commented Dec 9, 2021

Currently, only when the cr is installed the PATH env is updated with the cache directory, resulting in a working behavior for the first time but in consequents runs in the following error:

Looking up latest tag...
Discovering changed charts since 'test-0.0.8'...
Packaging chart 'charts/test'...
/tmp/_work/B5Gz2/_actions/helm/chart-releaser-action/v1.2.1/cr.sh: line 243: cr: command not found
Error: Process completed with exit code 127.

This might not be a problem in stateless runners since there the cr is always installed, but for stateful ones, its easy to replicate.

Signed-off-by: João Silva <j.f.silva@kigroup.de>
@afranzi
Copy link

afranzi commented Jan 11, 2022

Any update on moving forward with this PR, we are having the same issue? :)

@afranzi
Copy link

afranzi commented Jan 12, 2022

@cpanato could we get your review please? 😬

@mpbauer
Copy link

mpbauer commented Feb 2, 2022

I am facing the same issue with self-hosted GitHub Action runners and it would be really nice if this change would be approved soon.

@davidkarlsen davidkarlsen merged commit 974a695 into helm:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants