Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove go install tools and replace to use in the gh action and update base image #191

Merged
merged 8 commits into from
Jun 21, 2022
Merged

remove go install tools and replace to use in the gh action and update base image #191

merged 8 commits into from
Jun 21, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 17, 2022 •
edited
Loading

  • remove go install tools and replace to use in the gh action
  • update base image to alpine:3.16
  • add dedicate golangci-lint job

@cpanato
remove some go install tools and replace to use in the gh action
764bfab 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
update base image to alpine:3.16
83ecfeb 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
add dedicate golangci-lint job
242770a 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
remove setup.sh and update magefile
6031ab6 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
add golangci-lint config
ff2bb44 
Signed-off-by: cpanato <ctadeu@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 17, 2022
@cpanato
fix lints
b716477 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato changed the title remove some go install tools and replace to use in the gh action and update base image remove go install tools and replace to use in the gh action and update base image Jun 17, 2022
@cpanato cpanato marked this pull request as ready for review June 17, 2022 14:12
davidkarlsen
davidkarlsen reviewed Jun 19, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated
steps:
- uses: actions/setup-go@v3
with:
go-version: '1.18'
Copy link
Member

@davidkarlsen davidkarlsen Jun 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, this can point to the mod-file and select version automagically based on that: https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks @davidkarlsen PTAL

davidkarlsen
davidkarlsen approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@davidkarlsen davidkarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cpanato
update per feedback
bdc369b 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
add cache
ca6e4fa 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato merged commit 1e658d6 into helm:main Jun 21, 2022
@cpanato cpanato deleted the update branch June 21, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkarlsen davidkarlsen davidkarlsen approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpanato @davidkarlsen