-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove go install tools and replace to use in the gh action and update base image #191
Conversation
cpanato
commented
Jun 17, 2022
•
edited
Loading
edited
- remove go install tools and replace to use in the gh action
- update base image to alpine:3.16
- add dedicate golangci-lint job
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
.github/workflows/ci.yaml
Outdated
steps: | ||
- uses: actions/setup-go@v3 | ||
with: | ||
go-version: '1.18' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this can point to the mod-file and select version automagically based on that: https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks @davidkarlsen PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: cpanato <ctadeu@gmail.com>